Skip to content

fix(command-menu): replace hardcoded neutral-* utilities with theme tokens#10981

Open
creazyfrog wants to merge 1 commit into
shadcn-ui:mainfrom
creazyfrog:fix/10819-command-menu-theme-tokens
Open

fix(command-menu): replace hardcoded neutral-* utilities with theme tokens#10981
creazyfrog wants to merge 1 commit into
shadcn-ui:mainfrom
creazyfrog:fix/10819-command-menu-theme-tokens

Conversation

@creazyfrog

Copy link
Copy Markdown

Summary

  • Fixes [bug]: command menu hardcodes neutral-* colors instead of theme tokens #10819: The docs command menu (apps/v4/components/command-menu.tsx) hardcoded neutral-* Tailwind utilities for the dialog chrome and footer bar instead of using CSS theme tokens
  • On the shadcn default theme this looks identical, but the hardcoded colors drift when the component is used under any non-neutral base theme (where --popover, --muted, and --border are retinted)

Changes

  • apps/v4/components/command-menu.tsx line 403 (DialogContent): replaced ring-neutral-200/80 dark:bg-neutral-900 dark:ring-neutral-800 with bg-popover ring-foreground/5 dark:ring-foreground/10
  • apps/v4/components/command-menu.tsx line 442 (footer bar): replaced border-t-neutral-100 bg-neutral-50 dark:border-t-neutral-700 dark:bg-neutral-800 with border-border bg-muted/50

Testing

Docs-only component change. The visual output under the default (neutral) theme is unchanged — the token values resolve to the same colors. The fix becomes visible under non-neutral themes where --popover/--muted/--border differ from the neutral palette.

Closes #10819

🤖 Generated with Claude Code

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

@creazyfrog is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@creazyfrog creazyfrog force-pushed the fix/10819-command-menu-theme-tokens branch from 767750c to 946d013 Compare June 21, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: command menu hardcodes neutral-* colors instead of theme tokens

1 participant