Added include invalid pending queue items for the vault#2123
Open
russell-stern wants to merge 11 commits into
Open
Added include invalid pending queue items for the vault#2123russell-stern wants to merge 11 commits into
russell-stern wants to merge 11 commits into
Conversation
Contributor
✅ API Diff Results -
|
cedric-cordenier
previously approved these changes
Jun 4, 2026
prashantkumar1982
previously approved these changes
Jun 9, 2026
russell-stern
dismissed stale reviews from prashantkumar1982 and cedric-cordenier
via
256a23f
russell-stern
force-pushed
the
validate_observations
branch
from
4292fef to
256a23f
Compare
russell-stern
force-pushed
the
validate_observations
branch
from
5ce797f to
b7f9746
Compare
russell-stern
force-pushed
the
validate_observations
branch
from
16329fd to
7e603d9
Compare
…actkit/chainlink-common into validate_observations
pavel-raykov
reviewed
Jul 8, 2026
|
|
||
| // ObservationError is an item-level Err(E) contribution for a pending queue request. | ||
| // When set on Observation, the observation is an error contribution for that request id. | ||
| message ObservationError { |
Contributor
There was a problem hiding this comment.
any reason this is a separate proto and not inlined?
Contributor
Author
There was a problem hiding this comment.
Mostly for extensibility later on in case we want to add codes/types
russell-stern
changed the title
pavel-raykov
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.