PLEX-3129 EVM LP allow to fast forward to a block#2237
Open
dhaidashenko wants to merge 1 commit into
Open
Conversation
Contributor
|
👋 dhaidashenko, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an EVM Loop/gRPC API for advancing the Log Poller’s internal position to a specified block (“skip/fast-forward”), wiring it through the public types.EVMService interface, relayer gRPC server/client shims, and generated protobuf code.
Changes:
- Extended
types.EVMServicewithLPSkipToBlock(ctx, blockNumber)and added an Unimplemented stub. - Added
LPSkipToBlockunary RPC +LPSkipToBlockRequestto the EVM protobuf service and regeneratedevm.pb.go/evm_grpc.pb.go. - Updated Loop relayer and relayerset EVM gRPC client/server plumbing and updated the
EVMServicemock.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/relayer.go | Adds LPSkipToBlock to the public EVM service interface + unimplemented stub. |
| pkg/types/mocks/evm_service.go | Updates the autogenerated mock to include LPSkipToBlock. |
| pkg/loop/internal/relayerset/evm.go | Wires LPSkipToBlock through the relayerset EVM client/server adapters. |
| pkg/loop/internal/relayer/evm.go | Adds EVMClient.LPSkipToBlock and the gRPC server implementation method. |
| pkg/chains/evm/evm.proto | Adds the LPSkipToBlock RPC and request message to the EVM service definition. |
| pkg/chains/evm/evm.pb.go | Regenerated protobuf message/service bindings to include LPSkipToBlockRequest. |
| pkg/chains/evm/evm_grpc.pb.go | Regenerated gRPC client/server bindings to include LPSkipToBlock. |
Files not reviewed (3)
- pkg/chains/evm/evm.pb.go: Generated file
- pkg/chains/evm/evm_grpc.pb.go: Generated file
- pkg/types/mocks/evm_service.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+306
to
+309
| func (e *EVMClient) LPSkipToBlock(ctx context.Context, blockNumber int64) error { | ||
| _, err := e.grpcClient.LPSkipToBlock(ctx, &evmpb.LPSkipToBlockRequest{BlockNumber: blockNumber}) | ||
| return net.WrapRPCErr(err) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.