[SCSB-155] build with Numpy 2.0 release candidate - #1603
Open
zacharyburnett wants to merge 3 commits into
Open
Conversation
numpy>=2.0.0rc2 in build-system.requires
zacharyburnett
force-pushed
the
pin_numpy_build_requirement
branch
from
June 4, 2024 14:21
62e763a to
9a68e55
Compare
zacharyburnett
marked this pull request as ready for review
June 4, 2024 14:21
Collaborator
|
@zacharyburnett it's been a long wait on this one. We just had a release and need to do another soon and figured if numpy 2.0 isn't causing too much havoc we could merge it in. I am guess since numpy 2.0 it out, we can remove the |
zacharyburnett
commented
Jul 15, 2024
Collaborator
|
@zacharyburnett I have been holding off on this because of the dependencies of the JWST pipeline. I would like to bump to numpy 2.0 but am unsure if we are ready yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves SCSB-155
Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as
1.26this PR pins
numpy>=2.0.0rc2inbuild-system.requiresNote
this PR was generated automatically by
batchpr🤖