Skip to content

Mock crds client directly - #343

Open
braingram wants to merge 5 commits into
spacetelescope:mainfrom
braingram:mock_crds
Open

Mock crds client directly#343
braingram wants to merge 5 commits into
spacetelescope:mainfrom
braingram:mock_crds

Conversation

@braingram

@braingram braingram commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Closes #339
Closes #338

Updates tests that previously mocked stpipe functions to work-around not having a test crds to instead mock the crds client allowing the stpipe functions to be called. This exposed one missing _get_crds_parameters for a test class.

As these are only test changes no regtests were run.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.26%. Comparing base (0d5498d) to head (7009d63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   91.85%   92.26%   +0.41%     
==========================================
  Files          39       40       +1     
  Lines        3770     3803      +33     
==========================================
+ Hits         3463     3509      +46     
+ Misses        307      294      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Jul 23, 2026
@braingram
braingram marked this pull request as ready for review July 24, 2026 11:26
@braingram
braingram requested a review from a team as a code owner July 24, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed does not require an entry in `CHANGES.rst`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate stpipe crds mocking in tests Add unit tests for crds_client functions used by pipelines

1 participant