Skip to content

[SCSB-273] freeze ruff rules with explicit selection - #350

Open
zacharyburnett wants to merge 1 commit into
spacetelescope:mainfrom
zacharyburnett:scsb273_freeze_ruff_rules
Open

[SCSB-273] freeze ruff rules with explicit selection#350
zacharyburnett wants to merge 1 commit into
spacetelescope:mainfrom
zacharyburnett:scsb273_freeze_ruff_rules

Conversation

@zacharyburnett

@zacharyburnett zacharyburnett commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Resolves SCSB-273

ruff 0.16.0 added a lot more default rules; to avoid a bunch of new Ruff failures, we can explicitly set the rules we're using with select. The pre-0.16.0 default rules were select = ["E4", "E7", "E9", "F"]

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)

@zacharyburnett zacharyburnett self-assigned this Jul 27, 2026
@zacharyburnett zacharyburnett added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (0da1ee8) to head (a017656).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          39       39           
  Lines        3770     3770           
=======================================
  Hits         3463     3463           
  Misses        307      307           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zacharyburnett
zacharyburnett force-pushed the scsb273_freeze_ruff_rules branch 2 times, most recently from 91301dc to ef34000 Compare July 27, 2026 19:22
@zacharyburnett
zacharyburnett marked this pull request as ready for review July 27, 2026 19:22
@zacharyburnett
zacharyburnett requested a review from a team as a code owner July 27, 2026 19:22
@zacharyburnett
zacharyburnett force-pushed the scsb273_freeze_ruff_rules branch from f428c59 to cba9f58 Compare July 27, 2026 19:46
@zacharyburnett
zacharyburnett enabled auto-merge (squash) July 27, 2026 19:52
@zacharyburnett
zacharyburnett force-pushed the scsb273_freeze_ruff_rules branch from cba9f58 to a017656 Compare July 31, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed does not require an entry in `CHANGES.rst`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant