Fix wasmtime bump regexes#3606
Merged
itowlson merged 1 commit intoJul 9, 2026
Merged
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
fibonacci1729
approved these changes
Jul 9, 2026
fibonacci1729
left a comment
Collaborator
There was a problem hiding this comment.
not a bitcoin miner!
Collaborator
Author
I would use awk rather than sed for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug laid horribly bare by #3605.
I couldn't test properly in my fork because of tokens and keys and whatnot but I made it cat the munged Cargo.toml and it looked uh not obviously wrong. Well not obviously wrong to me anyway.
https://github.com/itowlson/spin/actions/runs/28987200598/job/86018887021#step:4:849