-
Notifications
You must be signed in to change notification settings - Fork 483
Improve rendering fidelity of the AST-to-source transpiler #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7201d70
Render nested generic type arguments in the AST-to-source transpiler
leonard84 52bb1ae
Add release notes entry for nested generic transpiler fix
leonard84 ddbbfbd
Render the elvis operator in its short form in the AST-to-source tran…
leonard84 dd021f1
Render attribute access with the at sign in the AST-to-source transpiler
leonard84 858817a
Render implicit-it closures without an arrow in the AST-to-source tra…
leonard84 05bb3e3
Render safe index access faithfully in the AST-to-source transpiler
leonard84 eb6fcfd
Keep numeric literal type suffixes in the AST-to-source transpiler
leonard84 625aa71
Render left-open ranges in the AST-to-source transpiler
leonard84 96d88d4
Render explicit type arguments of method calls in the AST-to-source t…
leonard84 6a03dcc
Add release notes entry for the additional transpiler rendering fixes
leonard84 e957171
Skip the default label for switches without one in the AST-to-source …
leonard84 d2d1ddc
Skip the finally block for try statements without one in the AST-to-s…
leonard84 9415b3b
Render the index variable of for-in loops in the AST-to-source transp…
leonard84 7f93a6c
Close the classloader created by the AST-to-source transpiler
leonard84 0892f8c
Mention the adopted upstream transpiler fixes in the release notes
leonard84 d4bd9e8
Adopt upstream's cosmetic rendering improvements in the AST-to-source…
leonard84 846e09c
Accept any classloader in the AST-to-source transpiler
leonard84 a56e2bd
Extract shared helpers in the AST-to-source transpiler
leonard84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...kframework/smoke/ast/AstSpec/nested_generic_type_arguments_are_rendered_faithfully.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| public java.util.Map<String, List<Integer>> nested() { | ||
| null | ||
| } | ||
|
|
||
| public java.util.List<? extends java.lang.Number> upperBounded() { | ||
| null | ||
| } | ||
|
|
||
| public <T extends java.lang.CharSequence> java.util.List<T> methodTypeParameter() { | ||
| null | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.