GECloud: Don't control charge rate percentage if we have a rate setting#4217
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GivEnergy GE Cloud Direct integration to avoid configuring (or relying on) charge/discharge percentage rate controls when a direct power rate register is available, preventing the percentage register from clamping the direct power setting.
Changes:
- Reset charge/discharge power percentage registers to 100% in
enable_default_options()when corresponding direct power registers exist. - Update GECloud auto-configuration to only populate
charge_rate_percent/discharge_rate_percentwhen direct power rate registers are absent. - Expand GECloud unit tests to cover the new precedence and reset behavior; bump Predbat version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/predbat/gecloud.py | Implements precedence of direct power registers over percentage registers and resets percentage to 100% when both exist; adjusts auto-config detection and arg wiring accordingly. |
| apps/predbat/tests/test_ge_cloud.py | Updates auto-config expectations and adds new tests validating percentage reset behavior and edge cases (alt register names, substring collision). |
| apps/predbat/predbat.py | Bumps THIS_VERSION from v8.44.7 to v8.44.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.