Better Windows' volume detection#1802
Open
oldergod wants to merge 1 commit into
Open
Conversation
oldergod
commented
Apr 20, 2026
|
|
||
| @Suppress("NOTHING_TO_INLINE") | ||
| internal inline fun Path.commonVolumeLetter(): Char? { | ||
| if (bytes.indexOf(SLASH) != -1) return null |
Member
Author
There was a problem hiding this comment.
This was preventing forward slashes from being accepted
Collaborator
|
I'm not comfortable deciding if this is valid or not. Deferring to Jesse. |
swankjesse
reviewed
Jun 18, 2026
swankjesse
left a comment
swankjesse
left a comment
Collaborator
There was a problem hiding this comment.
What’s the motivation here?
Unfortunately we’re in a small bind here because our API behaves the same regardless of what the host platform is, and treating C:/Windows as a drive letter also means we further aggravate this bug: #1460
Member
Author
|
This came up through this ticket on Wire square/wire#3215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows accepts both
/and\!