Skip to content

feat: add blas/ext/base/ndarray/dxsy#13045

Open
anandkaranubc wants to merge 4 commits into
stdlib-js:developfrom
anandkaranubc:feat/ndarray-dxsy
Open

feat: add blas/ext/base/ndarray/dxsy#13045
anandkaranubc wants to merge 4 commits into
stdlib-js:developfrom
anandkaranubc:feat/ndarray-dxsy

Conversation

@anandkaranubc

@anandkaranubc anandkaranubc commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Resolves stdlib-js/metr-issue-tracker#805

Description

What is the purpose of this pull request?

This pull request:

  • adds blas/ext/base/ndarray/dxsy

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Cursor+VS Code code-generation tools to help assist with the feature.

@stdlib-js/reviewers

@anandkaranubc
feat: add blas/ext/base/ndarray/dxsy
b2fb90d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc requested a review from a team June 22, 2026 03:55
@anandkaranubc anandkaranubc added Needs Review A pull request which needs code review. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). JavaScript Issue involves or relates to JavaScript. METR Pull request associated with the METR project. Feature Issue or pull request for adding a new feature. labels Jun 22, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 22, 2026
kgryte
kgryte reviewed Jun 22, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/ndarray/dxsy/docs/types/index.d.ts Outdated

/**
* Adds elements of a one-dimensional double-precision complex floating-point ndarray to the corresponding elements of a second one-dimensional double-precision complex floating-point ndarray and assigns the results to the second ndarray.
* Subtracts the second one-dimensional double-precision floating-point ndarray from the first one-dimensional double-precision floating-point ndarray and assigns the results to the second ndarray.

@kgryte kgryte Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Suggested change
* Subtracts the second one-dimensional double-precision floating-point ndarray from the first one-dimensional double-precision floating-point ndarray and assigns the results to the second ndarray.
* Subtracts the elements of an output one-dimensional double-precision floating-point ndarray from the corresponding elements in an input one-dimensional double-precision floating-point ndarray and assigns the results to the output ndarray.

?

@anandkaranubc anandkaranubc Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better Boss 🙌

@kgryte kgryte mentioned this pull request Jun 22, 2026
Open
7 tasks
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 22, 2026
@stdlib-bot

stdlib-bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/dxsy $\\color{green}111/111$
$\\color{green}+0.00\\%$ 		$\\color{green}3/3$
$\\color{green}+0.00\\%$ 		$\\color{green}1/1$
$\\color{green}+0.00\\%$ 		$\\color{green}111/111$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Merge branch 'develop' into feat/ndarray-dxsy
7dda2be
@anandkaranubc
chore: apply suggestions from review
5d9c08f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: apply suggestions from review
bffeb8c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. METR Pull request associated with the METR project. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/ndarray/dxsy

3 participants

@anandkaranubc @stdlib-bot @kgryte