Skip to content

chore: update keywords#13058

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-06-22
Jun 23, 2026
Merged

chore: update keywords#13058
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-06-22

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 2026-06-21 13:49 UTC-7 and 2026-06-22 01:52 UTC-7 (56 commits, range e6e7d42b..e0d79b3e).

This pull request:

  • Stray add keyword copied from an axpy-style sibling in lib/node_modules/@stdlib/blas/ext/base/sxsy/package.json (c7a7bd4); sxsy implements y = x - y, so replaced with subtract to align with cxsy, gxsy, and zxsy.
  • Same addsubtract keyword fix in lib/node_modules/@stdlib/blas/ext/base/dxsy/package.json (096398f); dxsy is the double-precision counterpart of the same operation.
  • Stale single keyword in lib/node_modules/@stdlib/blas/ext/base/zxsy/package.json (2a40396), copied verbatim from the single-precision cxsy sibling. Replaced with double to match the double-precision complex semantics; sits alongside the existing complex128/float64 tags.

Related Issues

Does this pull request have any related issues?

None.

Questions

No.

Other

Audit scope: the 56 first-parent commits to develop in the 24h window (range e6e7d42b..e0d79b3e). Four reviewer agents (two style, two bug) ran in parallel against the union diff and per-package files, cross-checking against sibling packages of similar complexity. Findings were de-duplicated and filtered to high-signal only — objective bugs and unambiguous copy-paste typos in package metadata. Findings that matched pre-existing patterns in sibling packages (e.g. lib/index.js shape in the *-sorted family) were intentionally dropped to avoid expanding scope beyond the diff window. A local report with the full audit trail (validated issues, dropped candidates and rationale, PR URL) lives at ~/drift-reports/commit-review-2026-06-22.md.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code running as a scheduled commit-review routine: four reviewer agents audited the last 24h of commits to develop, findings were filtered for high-signal items, and Philipp validated and applied the resulting one-line package.json keyword corrections.


@stdlib-js/reviewers


Generated by Claude Code

claude added 3 commits June 22, 2026 12:25
Replace stale `add` keyword (copied from an axpy-style sibling) with
`subtract` to match the package's semantics (y = x - y) and the
keyword convention used in `cxsy`, `gxsy`, and `zxsy`.

Ref: c7a7bd4
Replace stale `add` keyword (copied from an axpy-style sibling) with
`subtract` to match the package's semantics (y = x - y) and the
keyword convention used in `cxsy`, `gxsy`, and `zxsy`.

Ref: 096398f
Replace stale `single` keyword (carried over from the single-precision
`cxsy` sibling) with `double`. `zxsy` is the double-precision complex
variant; surrounding `complex128`/`float64` keywords already tag it
correctly.

Ref: 2a40396
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jun 22, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dxsy $\\color{green}405/405$
$\\color{green}+100.00\\%$
$\\color{green}26/26$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}405/405$
$\\color{green}+100.00\\%$
blas/ext/base/sxsy $\\color{green}405/405$
$\\color{green}+100.00\\%$
$\\color{green}26/26$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}405/405$
$\\color{green}+100.00\\%$
blas/ext/base/zxsy $\\color{green}435/435$
$\\color{green}+100.00\\%$
$\\color{green}26/26$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}435/435$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review June 23, 2026 05:09
@kgryte kgryte requested a review from a team June 23, 2026 05:09
@kgryte kgryte changed the title fix: correct copy-paste keyword leftovers in blas/ext/base/{sxsy,dxsy,zxsy} chore: update keywords Jun 23, 2026
@kgryte kgryte merged commit 0cd1435 into develop Jun 23, 2026
35 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-06-22 branch June 23, 2026 05:10
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants