COHIV-202: Refactor NK report code#316
Open
MarcoSteinacher wants to merge 6 commits into
Open
Conversation
MarcoSteinacher
force-pushed
the
dev/COHIV-202_refactor_nk_report
branch
from
April 13, 2026 14:14
432953a to
35edf02
Compare
MarcoSteinacher
force-pushed
the
dev/COHIV-202_refactor_nk_report
branch
from
April 13, 2026 14:20
35edf02 to
bbe9fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to split the legacy code in
report/nk_report.pyinto multiple files and classes inreport/nk/.Currently, only the simple cost type NkTotalCost is implemented and some tests. Refactoring of other cost types will follow.
I confirm that I have read the Contributor Agreement v1.1, agree to be bound on them and confirm that my contribution is compliant.