Skip to content

COHIV-257: update status field on Shares model#389

Draft
x4nd3r wants to merge 5 commits into
developfrom
dev/COHIV-257/update_share_status
Draft

COHIV-257: update status field on Shares model#389
x4nd3r wants to merge 5 commits into
developfrom
dev/COHIV-257/update_share_status

Conversation

@x4nd3r

@x4nd3r x4nd3r commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Current behaviour: there is no distinction in the "state" of a Share that has an end date in the past, it simply retains whatever state it had at the time that it lapsed.

Proposed behaviour: if the end date of a Share occurs in the past, assign it a new state value of "beendet", to indicate that it is no longer active.


I confirm that I have read the Contributor Agreement v1.1, agree to be bound on them and confirm that my contribution is compliant.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 669a9f53-c449-4492-af90-b8bcd423a911

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/COHIV-257/update_share_status

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  django/geno
  models.py 1036
  django/geno/tests
  data.py
  test_shares.py
Project Total  

This report was generated by python-coverage-comment-action

@x4nd3r
x4nd3r requested a review from AlwinEgger July 16, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant