Skip to content

feat: add a reconnect to the initial ldap connection #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveiliop56 merged 5 commits into from
Jun 30, 2026
Merged

feat: add a reconnect to the initial ldap connection #928

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab6a2b4
feat: add a reconnect to the initial ldap connection
steveiliop56 Jun 8, 2026
9f73f79
fix: check for nil ldap connection in reconnect
steveiliop56 Jun 8, 2026
6e7ead6
Merge branch 'main' into feat/ldap-reconnect
steveiliop56 Jun 28, 2026
b93cd05
fix: reduce reconnect time to around 7 seconds in startup
steveiliop56 Jun 28, 2026
2482259
fix: reduce heartbeat reconnect interval to one second
steveiliop56 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/service/ldap_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ func NewLdapService(

_, err := ldap.connect()

// Warn: This will hang the tinyauth startup for a good 45 seconds until it fails
if err != nil {
err = ldap.reconnect(10 * time.Second)
return nil, fmt.Errorf("failed to connect to ldap server: %w", err)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

Expand All @@ -79,7 +81,7 @@ func NewLdapService(
err := ldap.heartbeat()
if err != nil {
ldap.log.App.Warn().Err(err).Msg("LDAP connection heartbeat failed, attempting to reconnect")
if reconnectErr := ldap.reconnect(); reconnectErr != nil {
if reconnectErr := ldap.reconnect(5 * time.Second); reconnectErr != nil {
ldap.log.App.Error().Err(reconnectErr).Msg("Failed to reconnect to LDAP server")
continue
}
Expand Down Expand Up @@ -247,11 +249,11 @@ func (ldap *LdapService) heartbeat() error {
return nil
}

func (ldap *LdapService) reconnect() error {
func (ldap *LdapService) reconnect(interval time.Duration) error {
ldap.log.App.Info().Msg("Attempting to reconnect to LDAP server")

exp := backoff.NewExponentialBackOff()
exp.InitialInterval = 500 * time.Millisecond
exp.InitialInterval = interval
exp.RandomizationFactor = 0.1
exp.Multiplier = 1.5
exp.Reset()
Expand Down