Skip to content

Newlogo#909

Open
1984logo wants to merge 3 commits into
toml-lang:mainfrom
1984logo:newlogo
Open

Newlogo#909
1984logo wants to merge 3 commits into
toml-lang:mainfrom
1984logo:newlogo

Conversation

@1984logo

Copy link
Copy Markdown

I put the new TOML logos, marks and icons in this PR. Let me know if it works for you.

@eksortso

Copy link
Copy Markdown
Contributor

We have been discussing these new logos for a long time. Can we get a blessing to make them a part of the TOML project? @pradyunsg @mojombo

@ChristianSi ChristianSi mentioned this pull request Oct 28, 2022
@eksortso eksortso mentioned this pull request Nov 20, 2022

@eksortso eksortso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @1984logo you intended to say "config files for humans" with an "s"?
EDIT: Ignore this one. But look at the next one.

@eksortso eksortso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to correct a misspelling.

Comment thread logos/README.md Outdated
@septatrix

Copy link
Copy Markdown

Adding only the original vector files should be more than sufficient. Everyone should be able to convert it to the size they need and it prevents committing binary files to a repo (and also ensure there is a single source of truth).

Comment thread logos/README.md Outdated
@septatrix

Copy link
Copy Markdown

Also some of these icons like logos/monochrome/toml-mark-black-L.png seem to have an improper viewbox showing padding on some sides but not the others.

@1984logo

Copy link
Copy Markdown
Author

@septatrix

Adding only the original vector files should be more than sufficient.

Having raster versions of the logo in the repository is a common practice. It helps the quick adoption of the logo in most use cases.

Also some of these icons like logos/monochrome/toml-mark-black-L.png seem to have an improper viewbox showing padding on some sides but not the others.

You're right. Thank you for noticing. Let me fix that.

@hugovk hugovk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos:

Comment thread logos/README.md Outdated
Comment thread logos/README.md Outdated
Comment thread logos/README.md Outdated
Comment thread logos/README.md Outdated
Comment thread logos/README.md Outdated
@arp242

arp242 commented Mar 17, 2025

Copy link
Copy Markdown
Member

Overall I feel this looks rather nice, but I also find the uneven brackets a bit jarring at e.g. https://github.com/toml-lang/toml/blob/2412ba769caad047ea64ef885eb6f8d23ca4ad3a/README.md

The top is a bit shorter than the bottom, and there's a but of an indentation in the top-left and bottom-right one (to "fit" with the T and L).

It works quite nice on the small [T] icon/logo, but not so much on the [TOML] one. It just looks off?

I don't know if that's just me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants