Skip to content

Rename Samsung Internet as Samsung Browser #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishekraushan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename Samsung Internet as Samsung Browser #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions regexes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,13 +455,13 @@ user_agent_parsers:
- regex: '(EdgiOS|EdgA)/(\d+)(?:\.(\d+)|)(?:\.(\d+)|)(?:\.(\d+)|)'
family_replacement: 'Edge Mobile'

# Oculus Browser, should go before Samsung Internet
# Oculus Browser, should go before Samsung Browser
- regex: '(OculusBrowser)/(\d+)\.(\d+)(?:\.([0-9\-]+)|)'
family_replacement: 'Oculus Browser'

# Samsung Internet (based on Chrome, but lacking some features)
# Samsung Browser (based on Chrome, but lacking some features)
- regex: '(SamsungBrowser)/(\d+)\.(\d+)'
family_replacement: 'Samsung Internet'
family_replacement: 'Samsung Browser'

# Seznam.cz browser (based on WebKit)
- regex: '(SznProhlizec)/(\d+)\.(\d+)(?:\.(\d+)|)'
Expand Down
8 changes: 4 additions & 4 deletions tests/test_ua.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4588,25 +4588,25 @@ test_cases:
patch: '3'

- user_agent_string: 'Mozilla/5.0 (Linux; Android 5.0.1; SAMSUNG GT-I9506-ORANGE Build/LRX22C) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/2.1 Chrome/34.0.1847.76 Mobile Safari/537.36'
family: 'Samsung Internet'
family: 'Samsung Browser'
major: '2'
minor: '1'
patch:

- user_agent_string: 'Mozilla/5.0 (Linux; Android 5.0.2; SAMSUNG SM-T800 Build/LRX22G) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/3.0 Chrome/38.0.2125.102 Safari/537.36'
family: 'Samsung Internet'
family: 'Samsung Browser'
major: '3'
minor: '0'
patch:

- user_agent_string: 'Mozilla/5.0 (Linux; Android 5.1.1; SAMSUNG SM-G920F Build/LMY47X) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/3.2 Chrome/38.0.2125.102 Mobile Safari/537.36'
family: 'Samsung Internet'
family: 'Samsung Browser'
major: '3'
minor: '2'
patch:

- user_agent_string: 'Mozilla/5.0 (Linux; Android 5.0.2; SAMSUNG SM-T710 Build/LRX22G) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/3.5 Chrome/38.0.2125.102 Safari/537.36'
family: 'Samsung Internet'
family: 'Samsung Browser'
major: '3'
minor: '5'
patch:
Expand Down