Skip to content

feat!: Introduce New function with functional options pattern #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgoldstein0 merged 21 commits into from
Dec 7, 2025
Merged

feat!: Introduce New function with functional options pattern #96

Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c88c537
feat: NewFromSavedWithOptions
jkroepke Aug 14, 2025
79df3d8
Update uaparser/parser.go
jkroepke Aug 21, 2025
3f562eb
Merge branch 'master' into patch-1
jkroepke Sep 18, 2025
ce53386
Introduce New function with functional options pattern
jkroepke Sep 18, 2025
9dccb51
migrate data to functional option as well.
jkroepke Oct 16, 2025
ea8efb5
fix tests
jkroepke Oct 18, 2025
3700e77
add old functions back
jkroepke Oct 18, 2025
d635dc8
Update uaparser/deprecated.go
jkroepke Oct 19, 2025
0447e9d
Update uaparser/deprecated.go
jkroepke Oct 19, 2025
db9373c
fix tests
jkroepke Oct 19, 2025
5c9845f
WithRegexesDefinitions: Use a copied value of the struct
jkroepke Oct 19, 2025
6bb8070
WithRegexesDefinitions: Use a copied value of the struct
jkroepke Oct 19, 2025
c6642fc
defaultRegexesDefinitions always return a value to keep the immutability
jkroepke Oct 19, 2025
eccf038
RegexesDefinitions -> RegexDefinitions
jkroepke Oct 19, 2025
7c220ba
Update uaparser/parser.go
jkroepke Oct 20, 2025
4d5273c
WithMissesThreshold is a SortOption now
jkroepke Oct 20, 2025
6b9accc
create a copy before sort
jkroepke Oct 20, 2025
bfbb156
deep copy RegexDefinitions, if use sorted is enabled
jkroepke Dec 5, 2025
21fc7ba
Update uaparser/parser.go
jkroepke Dec 6, 2025
6a25700
Update uaparser/parser.go
jkroepke Dec 6, 2025
76a10f6
Update uaparser/parser.go
jkroepke Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion uaparser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,11 @@ func New(regexFile string) (*Parser, error) {
}

func NewFromSaved() *Parser {
parser, err := newFromBytes(DefinitionYaml, defaultParserConfig())
return NewFromSavedWithOptions(defaultParserConfig())
}

func NewFromSavedWithOptions(config *parserConfig) *Parser {
parser, err := newFromBytes(DefinitionYaml, config)
if err != nil {
// if the YAML is malformed, it's a programmatic error inside what
// we've statically-compiled in our binary. Panic!
Expand Down