Skip to content

Add parsing of Xiaomi devices#98

Closed
vbatoufflet wants to merge 1 commit into
ua-parser:masterfrom
vbatoufflet:feat/xiaomi-device
Closed

Add parsing of Xiaomi devices#98
vbatoufflet wants to merge 1 commit into
ua-parser:masterfrom
vbatoufflet:feat/xiaomi-device

Conversation

@vbatoufflet

Copy link
Copy Markdown

This PR makes it that the device parsing for Xiaomi devices stop returning:

Family: "Generic Smartphone"
Brand:  "Generic"
Model:  "Smartphone"

but instead:

Family: "Xiaomi 23053RN02A"
Brand:  "Xiaomi"
Model:  "23053RN02A"

@dgoldstein0 dgoldstein0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong repo to make the change to. uaparser/yaml.go is generated by https://github.com/ua-parser/uap-go/blob/master/build.sh from our submodule of ua-parser/uap-core. All regex changes ought to be first reviewed and merged into that repository. If you go that route, I'd be happy to accept a submodule update of uap-core to pull in any changes you contribute there.

@vbatoufflet

Copy link
Copy Markdown
Author

My bad, didn't catch that. Just created a new PR towards the proper repository ua-parser/uap-core#639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants