Cache Docker build layers with type=gha#86
Merged
Conversation
The docker.yml build had no build cache, so every run rebuilt the image from scratch. Add buildx type=gha cache scoped per platform so layers are reused across runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
docker.ymlbuild used no build cache, so every run rebuilt both images from scratch. Add buildxtype=ghacache scoped per platform.The GHCR build (required) populates the cache (
cache-to,mode=max); the optional DockerHub build reuses those layers viacache-from, so it becomes a cache hit rather than a second full rebuild — while keeping itscontinue-on-errorbest-effort semantics.cache-tocarriesignore-error=trueso a GitHub cache-service hiccup during cache export can't fail the required publish (cache is only an optimisation).