Skip to content

pr: use match instead of if/else chain #13004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cakebaker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pr: use match instead of if/else chain #13004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions src/uu/pr/src/pr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,24 +1351,20 @@ fn write_columns(
for row in table {
let indexes = row.len();
for (i, cell) in row.iter().enumerate() {
if cell.is_none() && options.merge_files_print.is_some() {
write_offset_spaces(out, options.offset_spaces)?;
out.write_all(
get_line_for_printing(options, &blank_line, columns, i, line_width, indexes)
.as_bytes(),
)?;
} else if cell.is_none() {
not_found_break = true;
break;
} else if cell.is_some() {
let file_line = cell.unwrap();

write_offset_spaces(out, options.offset_spaces)?;
out.write_all(
get_line_for_printing(options, file_line, columns, i, line_width, indexes)
.as_bytes(),
)?;
}
let line_to_print = match cell {
None if options.merge_files_print.is_some() => &blank_line,
None => {
not_found_break = true;
break;
}
Some(file_line) => file_line,
};

write_offset_spaces(out, options.offset_spaces)?;
out.write_all(
get_line_for_printing(options, line_to_print, columns, i, line_width, indexes)
.as_bytes(),
)?;
}
if not_found_break && feed_line_present {
break;
Expand Down
Loading