dd: fix stdout output#13066

Open

zhw2101024 wants to merge 2 commits into

uutils:mainfrom

zhw2101024:fix_stdout_output

zhw2101024 commented Jun 24, 2026

Contributor

Fixes #11557
Added DdError since io::Result as return type is not enough for this fix.
Many changes to pass the clippy checks, please tell me if there's better solutions.

oech3 reviewed

View reviewed changes

src/uu/dd/src/dd.rs Outdated

github-actions Bot commented Jun 24, 2026 •

edited

Loading

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)

oech3 reviewed

View reviewed changes

src/uu/dd/src/dd.rs Outdated

zhw2101024 force-pushed the fix_stdout_output branch from e82a5ee to 13f316c Compare

June 24, 2026 11:21

cakebaker changed the title ~~Fix stdout output~~ dd: fix stdout output

oech3 commented Jun 24, 2026 via email

Contributor

We don't aim generating 100% same error message with GNU. But exit code should be same and should not panic.

zhw2101024 force-pushed the fix_stdout_output branch from 13f316c to cb4dfeb Compare

June 24, 2026 12:20

oech3 reviewed

View reviewed changes

src/uu/dd/src/dd.rs Outdated

oech3 reviewed

View reviewed changes

src/uu/dd/src/dd.rs Outdated

oech3 reviewed

View reviewed changes

src/uu/dd/src/dd.rs Outdated

zhw2101024 added 2 commits

June 24, 2026 23:59


          add DdError for better error handling

60e9812


          fix stdout output

31993a7

zhw2101024 force-pushed the fix_stdout_output branch from cb4dfeb to 31993a7 Compare

June 24, 2026 16:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet