Skip to content

split: remove buffering#13069

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:split-unbuf
Jun 25, 2026
Merged

split: remove buffering#13069
cakebaker merged 1 commit into
uutils:mainfrom
oech3:split-unbuf

Conversation

@oech3

@oech3 oech3 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Closes #13068
I have no idea for tests.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Jun 24, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 10.67%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 320 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation split_bytes 390 µs 324.8 µs +20.1%
Memory split_number_chunks 941.3 KB 860.8 KB +9.35%
Simulation split_number_chunks 142.4 µs 138 µs +3.21%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:split-unbuf (d611474) with main (be93dc3)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker cakebaker merged commit f438cac into uutils:main Jun 25, 2026
174 of 175 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the split-unbuf branch June 25, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split: should not be buffered (remove BufWriter)

2 participants