Skip to content

split: replace OPT_ by options::#13070

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:split-c
Open

split: replace OPT_ by options::#13070
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:split-c

Conversation

@oech3

@oech3 oech3 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
  • replace OPT_ by options:: as other utils does.
  • Please split huge .rs file. This is difficult to parse by eye.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 10.64%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 320 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation split_bytes 390 µs 324.8 µs +20.08%
Memory split_number_chunks 941.3 KB 860.8 KB +9.35%
Simulation split_number_chunks 142.4 µs 138.1 µs +3.13%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:split-c (97ca1c2) with main (3b0bed6)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (f438cac) during the generation of this report, so 3b0bed6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant