fix: implement cleanup() to remove the PAT (#30)#39
Closed
ifauzeee wants to merge 1 commit into
Closed
Conversation
Member
ulises-jeremias
added a commit
that referenced
this pull request
Jul 15, 2026
Co-authored-by: ifauzeee <ifauzeee@users.noreply.github.com>
Member
|
Rebased on latest main (after #38 merged) and rebuilt dist/index.js. Pushing the fixed version to a new branch and will link it here. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup()insrc/main.tswas an empty@todo, even though README.md and action.yml state that the post-job step removes the PAT.Implemented it (#30):
git config --global --unset-all http.https://github.com/.extraheader(wrapped in try/catch so a missing header or unavailable git is harmless).GITHUB_TOKENviacore.exportVariable('GITHUB_TOKEN', '')so subsequent steps cannot reuse the token.Verification
npm run build && npm run packagesucceeds; bundled cleanup() performs the cleanup.Closes #30