fix: clarify architecture warning without version#48
Closed
cnYui wants to merge 1 commit into
Closed
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
Summary
architecturewithoutversionwarning so it describes V setup behavior instead of Node.jsVerification
npm test(23 passed, 5 existing Windows baseline failures; the same five failures reproduce on the unmodified663cc08827d1fc0532ee755b4dedbb183c11d06abaseline)npm run buildnpm run lintnpx prettier --check "**/*.ts"npm run packagegit diff --checkNote:
npm run format-checkis not usable as-is in PowerShell because the single-quoted glob is passed literally to Prettier as"'**/*.ts'". I ran the equivalent double-quoted Prettier command above.