Add CNPG cluster chart as vshnpostgresql#14
Closed
mikeshootzz wants to merge 6 commits into
Closed
Conversation
This copies the upstream helmchart for provisioning a cnpg cluster as-is without any modifications.
Since the upstream helmcharts for cloud native pg are licensed under the Apache-2.0 license, we have to give special notice for this chart and use the same license accordingly.
This adds the barman cloud plugin as a backup option for cnpg.
This aligns the documentation of vshnpostgresql with vshnmariadb
mikeshootzz
changed the title
mikeshootzz
requested review from
a team,
Kidswiss,
TheBigLee,
mdnix and
zugao
and removed request for
a team
zugao
requested changes
Nov 11, 2025
zugao
left a comment
zugao
left a comment
Contributor
There was a problem hiding this comment.
I think the name should be changed
| apiVersion: barmancloud.cnpg.io/v1 | ||
| kind: ObjectStore | ||
| metadata: | ||
| name: {{ include "cluster.backups.objectStoreName" . }} |
Contributor
There was a problem hiding this comment.
let's craft the name based on the release name
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ default (printf "%s-barman-plugin-s3-creds" (include "cluster.fullname" .)) .Values.backups.secret.name }} |
| kind: Secret | ||
| metadata: | ||
| {{- if eq .Values.backups.method "plugin" }} | ||
| name: {{ .Values.backups.endpointCA.name | default (printf "%s-barman-plugin-ca-bundle" (include "cluster.fullname" .)) | quote }} |
This uses the release name instead of the cluster fullname as a prefix for the barman object store related resources.
Kidswiss
requested changes
Nov 14, 2025
| name: {{ include "cluster.backups.objectStoreName" . }} | ||
| namespace: {{ include "cluster.namespace" . }} | ||
| labels: {{ include "cluster.labels" . | nindent 4 }} | ||
| spec: |
Contributor
There was a problem hiding this comment.
Probably doesn't make sense to export everything that the CRD has via the chart. Let's just implement what we need for the time being.
This simplifies the object store and its related resources to only expose what we actually need
Contributor
Author
|
We'll wait for the upstream implementation to be finished: cloudnative-pg/charts#680 and publish the upstream PR's chart to our GitHub registry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
make docschart/<chart-name>[
bug,enhancement,documentation,change,breaking,dependency]