Fix Sorting Bug on Pages Tab#7
Open
adhami03 wants to merge 3 commits into
Open
Conversation
…rting instead numeric sorting.
Member
|
First of all, thank you for your work. I tried your PR and I get an error: Uncaught TypeError: Cannot read property '0' of undefined jawstats_web.js:104 So the sorting won't work anymore. And I cant reproduce your issue, sorting looks fine. Even on the This month card pages, sorting works as expected. Please can you give some more info? The contribution best practices are to make a PR's from the branch feature/your-feature-name for a new features, fix/fix-develop or hotfix/fix-master for fixes, or at least from a develop branch to develop branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counts in the pages column on the Pages tab formats the counts with commas. This was breaking sorting because it appeared to be doing a text sort. This fixes the sort by stripping the commas from the data for sorting.