MDB-47201: try using clickhouse-keeper instead of zookeeper (stable) - #183
Draft
aak74 wants to merge 5 commits into
Draft
MDB-47201: try using clickhouse-keeper instead of zookeeper (stable)#183aak74 wants to merge 5 commits into
aak74 wants to merge 5 commits into
Conversation
mialinx
requested changes
Jul 12, 2026
| ) | ||
| if source: | ||
| # And acquire lock (then new_primary will create replication slot) | ||
| self.zk.acquire_lock(os.path.join(self.zk.HOST_REPLICATION_SOURCES, source), read_lock=True) |
Collaborator
There was a problem hiding this comment.
CRIT! Looks not fine.
Do CH and ZK have different protocols here ?
We expect that changing DCS implementation will not affect application logic at all, especially in so many places.
aak74
marked this pull request as draft
July 13, 2026 15:54
aak74
force-pushed
the
MDB-47201-chkeeper-stable
branch
from
July 14, 2026 15:32
686b8c0 to
e9839af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For testing purposes only. No need to merge.