Update ScatterPlotViewer README#6122
Open
lcjohnso wants to merge 1 commit into
Open
Conversation
Contributor
|
There’s also issue #5324, since the TESS light curve viewer is technical debt at this point, and TESS subjects can be displayed in the scatter plot viewer. |
Contributor
|
@lcjohnso what's the status of this PR? Would you still like it reviewed? Should it wait until Shaun is back from OOO to review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates out-of-date documentation for the ScatterPlotViewer to clarify that all coordinate data should be passed using
seriesDatastructure, not just in the case of wanting to support multiple series. The updates also clarify differences between the PH TESS LightCurveViewer (e.g., assumed subject media and JSON data formatting) and point to that viewer's README for viewer-specific details.Package
lib-classifier
Linked Issue and/or Talk Post
Closes #6118
How to Review
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrapordocker-compose up --buildand FEM works as expected