Skip to content

refactor: replace Object.assign with spread syntax #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eatyourgreens wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: replace Object.assign with spread syntax #7122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/lib-classifier/src/store/Classification/Classification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ const Classification = types
self.annotations.forEach(annotation => {
annotations = annotations.concat(annotation.toSnapshot())
})
snapshot = Object.assign({}, snapshot, { annotations })
return snapshot
return { ...snapshot, annotations }
},

// Use this to retrieve previous drawing or transcription task annotations.
Expand All @@ -38,7 +37,7 @@ const Classification = types
}
}))
.preProcessSnapshot(snapshot => {
let newSnapshot = Object.assign({}, snapshot)
let newSnapshot = { ...snapshot }
// generate classification IDs, if not present
newSnapshot.id = snapshot.id || cuid()
// convert any annotations arrays to a map
Expand All @@ -53,7 +52,7 @@ const Classification = types
return newSnapshot
})
.postProcessSnapshot(snapshot => {
const newSnapshot = Object.assign({}, snapshot)
const newSnapshot = { ...snapshot }
// convert annotations to an array
newSnapshot.annotations = Object.values(snapshot.annotations)
return newSnapshot
Expand Down
Loading