Implemented workspace support - #208
Closed
rasmus-kirk wants to merge 6 commits into
Closed
Conversation
rasmus-kirk
marked this pull request as ready for review
November 23, 2025 09:10
limemloh
reviewed
Nov 24, 2025
limemloh
left a comment
Contributor
There was a problem hiding this comment.
Please check that you can still verify a verifiable build from an older version of cargo-concordium with these changes.
| ## Unreleased | ||
|
|
||
| - Support specifying a profile using the `--profile` flag. | ||
| - Support for workspaces. |
Contributor
There was a problem hiding this comment.
Please add more detail to this, support for workspace is not saying much. Instead, describe what is now possible compared to before.
Co-authored-by: Emil Holm Gjørup <eg@concordium.com>
…smart-contract-tools into workspace-support
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We want
cargo-concordiumto support workspaces.cargo-concordium build--profileflagThere's still two issues remaining:
cargo concordium testwould fail when run in the workspace root, as the contract integration tests need to build the WASM first. I suggest refactoring and exposing the build function in this crate and then building the contract in the integration tests themselves, with the added bonus of making the integration tests part of rust's own testing ecosystem.Checklist
hard-to-understand areas.