Honor --skip-validate-spec=false instead of always disabling spec validation#24161
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Conversation
…idation When --skip-validate-spec is provided, Generate unconditionally called setValidateSpec(false), ignoring the value, so --skip-validate-spec false behaved like true. Pass the actual flag value via setValidateSpec(!skipValidateSpec). Signed-off-by: vmihaylov <vasiliy.mikhailov@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
--skip-validate-specCLI option always disables spec validation, even when explicitly set tofalse. InGenerate.java, when the option is provided the code unconditionally callsconfigurator.setValidateSpec(false), ignoring the actual boolean value, so--skip-validate-spec false(validation on) behaves identically to--skip-validate-spec true(validation off).Fix
Pass the actual value:
configurator.setValidateSpec(!skipValidateSpec).Test (fails before, passes after)
Added
GenerateTest#testSkipValidateSpecFalse, which asserts--skip-validate-spec falseenables validation, plustestSkipValidateSpecTruefor the documented skip behaviour.Before the fix:
After the fix:
AI assistance disclosure
This contribution was produced with the help of an AI pipeline. The pipeline processed a large amount of source code to surface suspected bugs, reproduced a subset of them with failing unit tests and generated candidate fixes, and prepared pull requests from the ones that held up. Each PR was then reviewed and verified by a human before being opened: the fix and test were checked by hand and the test was confirmed to fail before the change and pass after.
Summary by cubic
Honor
--skip-validate-spec=falseinopenapi-generator-cliso validation runs when explicitly set to false. The CLI now passes the actual flag value to the configurator (setValidateSpec(!skipValidateSpec)) and includes tests for both true and false cases.Written for commit 19465fc. Summary will update on new commits.