Skip to content

Honor --skip-validate-spec=false instead of always disabling spec validation #24161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vasiliy-mikhailov wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −1
Open

Honor --skip-validate-spec=false instead of always disabling spec validation #24161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator-cli/src/main/java/org/openapitools/codegen/cmd/Generate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ public void execute() {

// now override with any specified parameters
if (skipValidateSpec != null) {
configurator.setValidateSpec(false);
configurator.setValidateSpec(!skipValidateSpec);
}

if (verbose != null) {
Expand Down
28 changes: 28 additions & 0 deletions modules/openapi-generator-cli/src/test/java/org/openapitools/codegen/cmd/GenerateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,4 +457,32 @@ public void testQuietShort() {
public void testNPEWithInvalidSpecFile() {
setupAndRunTest("-i", "src/test/resources/npe-test.yaml", "-g", "java", "-o", "src/main/java", false, null);
}

@Test
public void testSkipValidateSpecTrue() {
setupAndRunGenericTest("--skip-validate-spec");
verify(configurator).setValidateSpec(false);
}

@Test
public void testSkipValidateSpecFalse() throws NoSuchFieldException, IllegalAccessException {
Cli.CliBuilder<Runnable> builder =
Cli.<Runnable>builder("openapi-generator-cli")
.withCommands(Generate.class);
Generate generate = (Generate) builder.build().parse(
new String[]{"generate", "-g", "java", "-o", "src/main/java", "-i", "src/test/resources/swagger.yaml"});
java.lang.reflect.Field field = Generate.class.getDeclaredField("skipValidateSpec");
field.setAccessible(true);
field.set(generate, false);
generate.configurator = configurator;
generate.generator = generator;
try {
generate.run();
} finally {
verify(configurator).setInputSpec("src/test/resources/swagger.yaml");
verify(configurator).setGeneratorName("java");
verify(configurator).setOutputDir("src/main/java");
}
verify(configurator).setValidateSpec(true);
}
}
Loading