fix(service-logs): normalize identical date range#2814
Merged
Conversation
rmnbrd
approved these changes
Jul 13, 2026
rmnbrd
left a comment
Contributor
There was a problem hiding this comment.
Tested and approved, LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alert links can generate service-log URLs where
startDate === endDate. These values were passed unchanged to Loki, resulting in a zero-length query range and no useful logs.This PR:
To review, open service logs with identical
startDateandendDatequery parameters and verify that logs are queried over the normalized one-hour range.Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintFocused validation completed:
git diff --checkThe Nx project target could not start its plugin worker in the isolated worktree, so Jest, ESLint, and Prettier were run directly on the affected files.
PR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release