fix: reject @ character in header names#13314
Conversation
Remove the exception that allowed '@' character in header names. According to RFC 9110 Section 5.1, header field names must consist only of tchar characters, and '@' is not a valid tchar. The previous fix for INKqa09141 incorrectly allowed '@' in header names. This patch removes that exception and adds a comment explaining the RFC requirement. Fixes apache#12082
|
Hello! This is my first contribution to Apache Traffic Server. Could you please trigger CI for this bug fix PR? Thank you! |
|
@mmustafasenoglu This is a bug fix from a standards point of view, but anyone relying on the |
|
Hi @JosiahWI, thanks for asking! I think both labels make sense here. While this is a bug fix for RFC 9110 compliance, the character could indeed be used in internal headers, so marking it as Incompatible is appropriate. I've added both Bug and Incompatible labels. Thanks! |
|
[approve ci] |
|
Hi, following up on this bug fix PR. It fixes the @ character validation in header names per RFC 9110. Would appreciate a review. Thank you! |
Summary
Remove the exception that allowed '@' character in header names.
Changes
Why
RFC 9110 Section 5.1 states that header field names must consist only of tchar characters:
'@' is not in this list, so header names containing '@' should be rejected with a 400 response.
The previous fix for INKqa09141 incorrectly allowed '@' in header names.
Fixes #12082