Skip to content

fix: reject @ character in header names #13314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmustafasenoglu wants to merge 1 commit into from
+4 −5
Closed

fix: reject @ character in header names #13314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/proxy/hdrs/MIME.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2426,12 +2426,11 @@ mime_parser_parse(MIMEParser *parser, HdrHeap *heap, MIMEHdrImpl *mh, const char
/////////////////////////////////////////////

/**
* Fix for INKqa09141. The is_token function fails for '@' character.
* Header names starting with '@' signs are valid headers. Hence we
* have to add one more check to see if the first parameter is '@'
* character then, the header name is valid.
* RFC 9110 Section 5.1: Header field names must consist only of
* tchar characters. The '@' character is not a valid tchar, so
* header names containing '@' should be rejected as invalid.
**/
if ((!ParseRules::is_token(*parsed)) && (*parsed != '@')) {
if (!ParseRules::is_token(*parsed)) {
continue; // toss away garbage line
}

Expand Down