[camera_android_camerax] Setup agent skills camerax by reidbaker · Pull Request #11930 · flutter/packages

reidbaker · 2026-06-17T22:09:06Z

Setup the new agent skills architecture for camera_android_camerax:
Taking over from #11895

Remotely managed Skills: Third-party are in a top level directory pr remote repo so that licenses can be included. Then they are symlinked into packages that want them.
Published Skills: Added a new empty directory for skills that are for users of camera_android_camerax.
Contributor Skills: Added a new directory for contributor skills and authored an internal check-readiness skill configured to enforce repository hygiene.
Linter & Safety: Pinned dart_skills_lint to the newly supported individual_skills hash. Added EnforceTrackedSkillsPreventPublishingRule in tests to enforce that tracked skills are strictly configured with the prevent-skills-sh-publishing rule in dart_skills_lint.yaml to prevent accidental publishing.
Tooling changes:

Future changes:

migrate bash script to dart
make analyze run on .agents/skills/* directories
update the tooling to not need changelog and versioning if you modify .agents/skills

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

- Add dart_skills_lint dependency and configuration - Create .agents/skills and skills directories with documentation - Set up isolated third_party skills installation for remote skills - Symlink remote skills into .agents/skills - Add validate_skills_test.dart for CI integration

reidbaker · 2026-06-17T22:09:34Z

No changelog needed because none of the changes are user facing only contributor facing.

gemini-code-assist

Code Review

This pull request adds local and third-party AI agent skills to the camera_android_camerax package, including configuration files, tests, and documentation for managing them. Feedback on these changes identifies a missing verification script (check.sh) referenced in the readiness skill, an invalid license file containing a 404 error for the anthropics-skills dependency, a violation of Dart API boundaries due to importing internal src/ files in a test, and fragile path parsing in tracked_skills_publishing_test.dart that could fail in monorepo CI environments.

camsim99

Left some high level questions!

…ments

…sInternalRule

reidbaker · 2026-06-18T23:08:14Z

@camsim99 I have some work happening to turn this into dart code but if you are ok with it I would like to land that change independently.

reidbaker · 2026-06-19T19:21:20Z

      return true;
    }

-    if (!getBoolArg(_allowPrereleaseFlag)) {


this code was not deleted only moved.

camsim99

LGTM just had some questions about EnforceTrackedSkillsInternalRule for my own understanding! Sorry for the delayed review!

camsim99 · 2026-06-22T15:27:20Z

Why does this live within the camera_android_camerax plugin? Assuming this might be something we would want available to all plugins but we are just starting with it here?

Also why is it in the test/ directory? Is that standard for custom skill lints?

Why does this live within the camera_android_camerax plugin? Assuming this might be something we would want available to all plugins but we are just starting with it here?

There is already a lint that ensures that skills that have the lint enabled are not published. This is more of a meta test that makes sure that for this package (later repo) that we have configured the skills correctly.

Also why is it in the test/ directory? Is that standard for custom skill lints?
I am still working on the standard for where custom lints should live more broadly in dart packages. For this repo the lint will likely move to the repo tooling directory the first time we have another package adopt skills and want to enforce this configuration. You can think of custom lints kind of like test utils classes.

stuartmorgan-g · 2026-06-22T16:10:24Z

@@ -0,0 +1,26 @@
+Copyright 2026 The Flutter Authors. All rights reserved.


Why is Flutter code in a third_party directory?

Open to feedback on this but this is where skills that are managed by npx skills are located. That includes flutter skills because I am trying to keep the patterns the same. There will also be dart licensed skills in third_party.

stuartmorgan-g · 2026-06-22T16:13:55Z

@@ -0,0 +1,23 @@
+# Third-Party Agent Skills


Can we make a third_party/skills/ that contains this and all the skills, instead of making the individual skills peers of third_party/packages/, and having the README for all of third-party sound like it's about skills?

done I went with skill-repos because the string "skills" tends to be a magnet for crawlers.

reidbaker · 2026-06-22T16:36:00Z

I talked to @stuartmorgan-g out of band and we have a better way of determining what skills should be configured with dont publish check. I am going to resolve the paths for all the skills and filter out third_party. Holding landing this pr for that change.

…tPublishingRule

…ks/docs

…nces

auto-submit · 2026-06-22T18:54:22Z

autosubmit label was removed for flutter/packages/11930, because - The status or check suite Windows_x64 dart_unit_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ix Windows CI

…r#188383) flutter/packages@cd5194a...7d84a69 2026-06-22 engine-flutter-autoroll@skia.org Roll Flutter (stable) from c9a6c48 to e1fd963 (6 revisions) (flutter/packages#11958) 2026-06-22 1063596+reidbaker@users.noreply.github.com [camera_android_camerax] Setup agent skills camerax (flutter/packages#11930) 2026-06-22 engine-flutter-autoroll@skia.org Roll Flutter from 707e50f to e228771 (7 revisions) (flutter/packages#11957) 2026-06-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 6.0.2 to 7.0.0 in the all-github-actions group (flutter/packages#11953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

reidbaker added 7 commits June 17, 2026 16:49

feat: Add check-readiness skill

26b37ae

feat: Add local check-readiness skill and configure linter

d825767

test: ensure tracked skills cannot be published accidentally

f7f0646

build: pin dart_skills_lint to support individual_skills

ea27e43

test: rewrite tracked skills test to use ValidationSession API

9ac31a2

test: fix analyzer warnings

87cfaf1

reidbaker added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jun 17, 2026

flutter-dashboard Bot added the CICD Run CI/CD label Jun 17, 2026

github-actions Bot added the p: camera label Jun 17, 2026

reidbaker marked this pull request as draft June 17, 2026 22:09

gemini-code-assist Bot reviewed Jun 17, 2026

View reviewed changes

camsim99 self-requested a review June 17, 2026 22:53

build: update dart_skills_lint to 8f85e82b on main

acbcc3e

github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026

camsim99 reviewed Jun 18, 2026

View reviewed changes

Comment thread third_party/anthropics-skills/LICENSE Outdated

Comment thread third_party/README.md Outdated

Comment thread packages/camera/camera_android_camerax/.agents/skills/check-readiness/SKILL.md

test: rewrite tracked skills test to use yaml parsing, address PR com…

7eabf5f

…ments

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

test: revert yaml parsing, use public ValidationSession from repo

9e0d9e5

github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026

test: revert to ValidationSession and use ignore implementation_imports

6b68664

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

test: replace yaml parsing with custom skill rule EnforceTrackedSkill…

0942453

…sInternalRule

github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026

test: extract EnforceTrackedSkillsInternalRule to its own file with docs

9471107

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

reidbaker commented Jun 18, 2026

View reviewed changes

reidbaker marked this pull request as ready for review June 18, 2026 23:50

ci: allow dart_skills_lint in packages

c4e832f

Fix .gitignore un-ignore rule overreach

16e3f28

github-actions Bot removed the CICD Run CI/CD label Jun 19, 2026

reidbaker commented Jun 19, 2026

View reviewed changes

reidbaker added the CICD Run CI/CD label Jun 19, 2026

reidbaker requested a review from camsim99 June 19, 2026 19:30

camsim99 approved these changes Jun 22, 2026

View reviewed changes

reidbaker requested a review from stuartmorgan-g June 22, 2026 16:04

stuartmorgan-g reviewed Jun 22, 2026

View reviewed changes

Rename EnforceTrackedSkillsInternalRule to EnforceTrackedSkillsPreven…

83638ff

…tPublishingRule

github-actions Bot removed the CICD Run CI/CD label Jun 22, 2026

reidbaker added the CICD Run CI/CD label Jun 22, 2026

reidbaker requested a review from stuartmorgan-g June 22, 2026 18:36

Move third-party skills to third_party/skill-repos/ and update symlin…

d93c81e

…ks/docs

github-actions Bot removed the CICD Run CI/CD label Jun 22, 2026

Move third-party README to third_party/skill-repos/ and update refere…

7c080f9

…nces

flutter-dashboard Bot added the CICD Run CI/CD label Jun 22, 2026

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2026

Canonicalize paths for EnforceTrackedSkillsPreventPublishingRule to f…

51ecf16

…ix Windows CI

github-actions Bot removed the CICD Run CI/CD label Jun 22, 2026

Add path dependency to camera_android_camerax dev_dependencies

2271f28

flutter-dashboard Bot added the CICD Run CI/CD label Jun 22, 2026

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2026

auto-submit Bot merged commit e347ab4 into main Jun 22, 2026
88 checks passed

auto-submit Bot deleted the setup-agent-skills-camerax branch June 22, 2026 19:24

engine-flutter-autoroll mentioned this pull request Jun 23, 2026

Roll Packages from cd5194a5f049 to 7d84a699def1 (4 revisions) flutter/flutter#188383

Merged

		@@ -0,0 +1,26 @@
		Copyright 2026 The Flutter Authors. All rights reserved.

Uh oh!

Conversation

reidbaker commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

reidbaker commented Jun 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Jun 22, 2026

Uh oh!

auto-submit Bot commented Jun 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reidbaker commented Jun 17, 2026 •

edited

Loading