Skip to content
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ee20fa7
feat: Set up agent skills management architecture
reidbaker Jun 17, 2026
26b37ae
feat: Add check-readiness skill
reidbaker Jun 17, 2026
d825767
feat: Add local check-readiness skill and configure linter
reidbaker Jun 17, 2026
f7f0646
test: ensure tracked skills cannot be published accidentally
reidbaker Jun 17, 2026
ea27e43
build: pin dart_skills_lint to support individual_skills
reidbaker Jun 17, 2026
9ac31a2
test: rewrite tracked skills test to use ValidationSession API
reidbaker Jun 17, 2026
87cfaf1
test: fix analyzer warnings
reidbaker Jun 17, 2026
acbcc3e
build: update dart_skills_lint to 8f85e82b on main
reidbaker Jun 18, 2026
7eabf5f
test: rewrite tracked skills test to use yaml parsing, address PR com…
reidbaker Jun 18, 2026
9e0d9e5
test: revert yaml parsing, use public ValidationSession from repo
reidbaker Jun 18, 2026
6b68664
test: revert to ValidationSession and use ignore implementation_imports
reidbaker Jun 18, 2026
0942453
test: replace yaml parsing with custom skill rule EnforceTrackedSkill…
reidbaker Jun 18, 2026
9471107
test: extract EnforceTrackedSkillsInternalRule to its own file with docs
reidbaker Jun 18, 2026
c4e832f
ci: allow dart_skills_lint in packages
reidbaker Jun 18, 2026
acc34a5
test: fix internal rule validation feedback
reidbaker Jun 18, 2026
288e5ec
Fix missing copyright headers in check-readiness agent skill
reidbaker Jun 19, 2026
43be3d1
Support .pubignore in publish-check
reidbaker Jun 19, 2026
8d17949
Add tests for publish_check pubignore parsing
reidbaker Jun 19, 2026
81c1c52
Fix .gitignore for check-readiness skill and symlinked skills
reidbaker Jun 19, 2026
438537c
Revert un-ignoring of symlinked skills
reidbaker Jun 19, 2026
f64190b
Add TODO for tracking dart-lang/pub issue 4841
reidbaker Jun 19, 2026
14d7cfc
Group pubignore tracking tests under issue 4841
reidbaker Jun 19, 2026
d7f024e
Move TODO out of group name
reidbaker Jun 19, 2026
bc37ae6
Fix analyzer warnings
reidbaker Jun 19, 2026
16e3f28
Fix .gitignore un-ignore rule overreach
reidbaker Jun 19, 2026
83638ff
Rename EnforceTrackedSkillsInternalRule to EnforceTrackedSkillsPreven…
reidbaker Jun 22, 2026
d93c81e
Move third-party skills to third_party/skill-repos/ and update symlin…
reidbaker Jun 22, 2026
7c080f9
Move third-party README to third_party/skill-repos/ and update refere…
reidbaker Jun 22, 2026
51ecf16
Canonicalize paths for EnforceTrackedSkillsPreventPublishingRule to f…
reidbaker Jun 22, 2026
2271f28
Add path dependency to camera_android_camerax dev_dependencies
reidbaker Jun 22, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .repo_tool_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ allowed_dependencies:
# Google-owned packages
- _discoveryapis_commons
- adaptive_navigation
- dart_skills_lint
- googleapis
- googleapis_auth
- json_annotation
Expand Down
12 changes: 12 additions & 0 deletions packages/camera/camera_android_camerax/.agents/skills/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Ignore everything by default
*

# Un-ignore specific checked-in skills
# (Add specific contributor skills here as they are created)
!check-readiness/

# Keep essential configuration and docs
!.gitignore
!README.md
!ignore.json
!flutter_skills_ignore.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Agent Skills

This directory contains skills intended for repository maintainers and contributors. Local, checked-in skills are evaluated by `dart_skills_lint` and should be configured to prevent publishing to pub.dev.

**Note on Remotely Managed Skills:**
Skills that are remotely defined and managed using `npx skills` should **not** be installed directly into this directory. Instead, they must be installed into the repository root's `third_party/` directory to comply with third-party code policies. Once installed there, they should be symlinked into this directory.

Please see the `third_party/README.md` file at the root of the repository for specific rules and instructions on adding new remote skills.
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
name: check-readiness
description: Run this skill to check if the repository is ready for new work. Use this skill whenever the user asks to "check readiness", "see if we are ready to start work", or when starting a new task in the camera_android_camerax package.
metadata:
internal: true
---
# Check Readiness

This skill verifies that the local environment is properly configured and clean before starting new work in the `camera_android_camerax` package.

## Instructions
Run the bundled verification script ([scripts/check.sh](scripts/check.sh)) to perform the automated environment checks:
```bash
bash .agents/skills/check-readiness/scripts/check.sh
Comment thread
reidbaker marked this conversation as resolved.
Comment thread
reidbaker marked this conversation as resolved.
```

### Handling the Results
1. **If the script succeeds:** Inform the user that the environment is clean, dependencies are resolved, and it is ready for new work.
2. **If the script fails:** Explain exactly which check failed (e.g., git is not clean, a symlink is broken, Flutter is missing from PATH) and offer to help resolve it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camsim99 I have some work happening to turn this into dart code but if you are ok with it I would like to land that change independently.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
#!/bin/bash

# Stop on first error
set -e

# Get the directory of this script, then go up to camera_android_camerax root
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
CAMERAX_DIR="$SCRIPT_DIR/../../../.."

echo "🔍 Checking if environment is ready for new work..."

# 1. Check symlinks resolve
echo "1️⃣ Checking skill symlinks..."
broken_links=$(find "$CAMERAX_DIR/.agents/skills" -type l ! -exec test -e {} \; -print)
if [ -n "$broken_links" ]; then
echo "❌ Error: Found broken symlinks in .agents/skills:"
echo "$broken_links"
exit 1
fi
echo "✅ All symlinks resolve correctly."

# 2. Check git state
echo "2️⃣ Checking git state..."
# Check the whole repository git state
if [ -n "$(git status --porcelain)" ]; then
echo "❌ Error: Git working directory is not clean. Please commit or stash your changes before starting new work."
exit 1
fi
Comment thread
reidbaker marked this conversation as resolved.
echo "✅ Git working directory is clean."

# 3. Check dart and flutter
echo "3️⃣ Checking Flutter and Dart..."
if ! command -v flutter &> /dev/null; then
echo "❌ Error: 'flutter' is not on the PATH."
exit 1
fi
if ! command -v dart &> /dev/null; then
echo "❌ Error: 'dart' is not on the PATH."
exit 1
fi
echo "✅ Flutter and Dart are on the PATH."

# 4. Check dependencies in camera_android_camerax
echo "4️⃣ Checking dependencies in camera_android_camerax..."
cd "$CAMERAX_DIR"
if ! flutter pub get; then
echo "❌ Error: Failed to resolve dependencies."
exit 1
fi
echo "✅ Dependencies are resolved and ready."

echo "🎉 Environment is fully ready!"
10 changes: 10 additions & 0 deletions packages/camera/camera_android_camerax/dart_skills_lint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
dart_skills_lint:
rules:
check-relative-paths: error
check-trailing-whitespace: error
directories:
- path: "skills"
individual_skills:
- path: ".agents/skills/check-readiness"
rules:
prevent-skills-sh-publishing: error
6 changes: 6 additions & 0 deletions packages/camera/camera_android_camerax/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,15 @@ dependencies:

dev_dependencies:
build_runner: ^2.2.0
dart_skills_lint:
git:
url: https://github.com/flutter/skills.git
path: tool/dart_skills_lint
ref: 8f85e82be6da429980f7cfe84f2f214a06cbfee1
flutter_test:
sdk: flutter
leak_tracker_flutter_testing: any
logging: ^1.2.0
mockito: ^5.4.4
pigeon: ^26.1.4

Expand Down
3 changes: 3 additions & 0 deletions packages/camera/camera_android_camerax/skills/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Published Skills

This directory contains AI agent skills that are intended to be published to pub.dev.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this live within the camera_android_camerax plugin? Assuming this might be something we would want available to all plugins but we are just starting with it here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why is it in the test/ directory? Is that standard for custom skill lints?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this live within the camera_android_camerax plugin? Assuming this might be something we would want available to all plugins but we are just starting with it here?

There is already a lint that ensures that skills that have the lint enabled are not published. This is more of a meta test that makes sure that for this package (later repo) that we have configured the skills correctly.

Also why is it in the test/ directory? Is that standard for custom skill lints?
I am still working on the standard for where custom lints should live more broadly in dart packages. For this repo the lint will likely move to the repo tooling directory the first time we have another package adopt skills and want to enforce this configuration. You can think of custom lints kind of like test utils classes.

Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:io';

import 'package:dart_skills_lint/dart_skills_lint.dart';

/// A custom lint rule that enforces that all skills tracked in version control
/// are marked as internal.
///
/// This rule is specifically used to prevent the accidental publishing of
/// workspace-specific agent skills to the global public skills registry. It
/// uses `git ls-files` to determine if a skill directory is checked into git,
/// and if it is, strictly requires that the `metadata: internal: true`
/// frontmatter is present in the `SKILL.md` file.
class EnforceTrackedSkillsInternalRule extends SkillRule {
@override
String get name => 'enforce-tracked-skills-internal';

@override
AnalysisSeverity get severity => AnalysisSeverity.error;

@override
Future<List<ValidationError>> validate(SkillContext context) async {
// Check if any files in the skill directory are tracked in git
final ProcessResult processResult = await Process.run('git', ['ls-files', context.directory.path]);
final String output = (processResult.stdout as String).trim();
Comment thread
reidbaker marked this conversation as resolved.
Outdated
if (output.isEmpty) {
// Not tracked by git, no enforcement needed
return [];
}

final Object? yaml = context.parsedYaml;
if (yaml == null) {
return [
ValidationError(
ruleId: name,
severity: severity,
file: 'SKILL.md',
message: 'Tracked skills must have "metadata: internal: true" in SKILL.md frontmatter.',
)
];
}

final Object? metadata = (yaml as Map)['metadata'];
if (metadata is! Map || metadata['internal'] != true) {
Comment thread
reidbaker marked this conversation as resolved.
Outdated
return [
ValidationError(
ruleId: name,
severity: severity,
file: 'SKILL.md',
message: 'Tracked skills must have "metadata: internal: true" in SKILL.md frontmatter.',
)
];
}

return [];
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import 'dart:async';

import 'package:dart_skills_lint/dart_skills_lint.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:logging/logging.dart';

import 'enforce_tracked_skills_internal_rule.dart';

void main() {
test('Validate Skills', () async {
final Level oldLevel = Logger.root.level;
Logger.root.level = Level.ALL;
final StreamSubscription<LogRecord> subscription = Logger.root.onRecord.listen((record) {
debugPrint(record.message);
});

try {
final Configuration config = await ConfigParser.loadConfig();
final bool isValid = await validateSkills(
config: config,
customRules: [EnforceTrackedSkillsInternalRule()],
);
expect(isValid, isTrue, reason: 'Skills validation failed. See above for details.');
} finally {
Logger.root.level = oldLevel;
await subscription.cancel();
}
});
}
23 changes: 23 additions & 0 deletions third_party/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Third-Party Agent Skills

To comply with third-party code policies, all remotely managed agent skills (installed via `npx skills`) must be isolated in this `third_party/` directory before being symlinked to specific project `.agents/skills` directories.

## Rules for Adding New Remote Skills

When adding a new remote skill, you must follow this exact structure and process:

1. **Folder per Repository:** Create a new folder under `third_party/` named uniquely after the GitHub repository the skill originates from (e.g., `third_party/dart-lang-skills`).

2. **Installation:** Run the `npx skills` command from *within* that new repository folder. This ensures the `skills-lock.json` file is correctly generated inside the subfolder. All `skills-lock.json` files must be generated by the CLI, not manually crafted.
```bash
cd third_party/<repo-name>
npx skills add <author/repo> --skill <skill-name> -y
```

3. **License Requirement:** You **must** download and retain the original `LICENSE` file from the remote repository and place it directly inside the `third_party/<repo-name>` subfolder.

4. **Symlinking:** Once installed, symlink the newly downloaded skill into the appropriate plugin's `.agents/skills` directory using a relative symlink.
```bash
cd packages/<plugin-name>/.agents/skills
ln -s ../../../../../third_party/<repo-name>/.agents/skills/<skill-name> <skill-name>
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
---
name: dart-add-unit-test
description: Write and organize unit tests for functions, methods, and classes using `package:test`. Use when creating new logic or fixing bugs to ensure code remains correct and regression-free.
metadata:
model: models/gemini-3.1-pro-preview
last_modified: Fri, 24 Apr 2026 15:07:58 GMT
---
# Testing Dart and Flutter Applications

## Contents
- [Structuring Test Files](#structuring-test-files)
- [Writing Tests](#writing-tests)
- [Executing Tests](#executing-tests)
- [Test Implementation Workflow](#test-implementation-workflow)
- [Examples](#examples)

## Structuring Test Files
Organize test files to mirror the `lib` directory structure to maintain predictability.

* Place all test code within the `test` directory at the root of the package.
* Append `_test.dart` to the end of all test file names (e.g., `lib/src/utils.dart` should be tested in `test/src/utils_test.dart`).
* If writing integration tests, place them in an `integration_test` directory at the root of the package.

## Writing Tests
Utilize `package:test` as the standard testing library for Dart applications.

* Import `package:test/test.dart` (or `package:flutter_test/flutter_test.dart` for Flutter).
* Group related tests using the `group()` function to provide shared context.
* Define individual test cases using the `test()` function.
* Validate outcomes using the `expect()` function alongside matchers (e.g., `equals()`, `isTrue`, `throwsA()`).
* Write asynchronous tests using standard `async`/`await` syntax. The test runner automatically waits for the `Future` to complete.
* Manage test setup and teardown using `setUp()` and `tearDown()` callbacks.
* If testing code that relies on dependency injection, use `package:mockito` alongside `package:test` to generate mock objects, configure fixed scenarios, and verify interactions.

## Executing Tests
Select the appropriate test runner based on the project type and test location.

* If working on a pure Dart project, execute tests using the `dart test` command.
* If working on a Flutter project, execute tests using the `flutter test` command.
* If running integration tests, explicitly specify the directory path, as the default runner ignores it: `dart test integration_test` or `flutter test integration_test`.

## Test Implementation Workflow

Follow this sequential workflow when implementing new test suites. Copy the checklist to track your progress.

### Task Progress
- [ ] 1. Create the test file in the `test/` directory, ensuring the `_test.dart` suffix.
- [ ] 2. Import `package:test/test.dart` and the target library.
- [ ] 3. Define a `main()` function.
- [ ] 4. Initialize shared resources or mocks using `setUp()`.
- [ ] 5. Write `test()` cases grouped by functionality using `group()`.
- [ ] 6. Execute the test suite using the appropriate CLI command.
- [ ] 7. **Feedback Loop**: Run test -> Review stack trace for failures -> Fix implementation or assertions -> Re-run until passing.

## Examples

### Standard Unit Test Suite
Demonstrates grouping, setup, synchronous, and asynchronous testing.

```dart
import 'package:test/test.dart';
import 'package:my_package/calculator.dart';

void main() {
group('Calculator', () {
late Calculator calc;

setUp(() {
calc = Calculator();
});

test('adds two numbers correctly', () {
expect(calc.add(2, 3), equals(5));
});

test('handles asynchronous operations', () async {
final result = await calc.fetchRemoteValue();
expect(result, isNotNull);
expect(result, greaterThan(0));
});
});
}
```

### Mocking with Mockito
Demonstrates configuring a mock object for dependency injection testing.

```dart
import 'package:test/test.dart';
import 'package:mockito/mockito.dart';
import 'package:mockito/annotations.dart';
import 'package:my_package/api_client.dart';
import 'package:my_package/data_service.dart';

// Generate the mock using build_runner: dart run build_runner build
@GenerateNiceMocks([MockSpec<ApiClient>()])
import 'data_service_test.mocks.dart';

void main() {
group('DataService', () {
late MockApiClient mockApiClient;
late DataService dataService;

setUp(() {
mockApiClient = MockApiClient();
dataService = DataService(apiClient: mockApiClient);
});

test('returns parsed data on successful API call', () async {
// Configure the mock
when(mockApiClient.get('/data')).thenAnswer((_) async => '{"id": 1}');

// Execute the system under test
final result = await dataService.fetchData();

// Verify outcomes and interactions
expect(result.id, equals(1));
verify(mockApiClient.get('/data')).called(1);
});
});
}
```
Loading
Loading