Skip to content

OSD custom elements: add 16-bit icon support#2643

Open
error414 wants to merge 2 commits into
iNavFlight:maintenance-10.xfrom
error414:error414/feature/16bits-icons
Open

OSD custom elements: add 16-bit icon support#2643
error414 wants to merge 2 commits into
iNavFlight:maintenance-10.xfrom
error414:error414/feature/16bits-icons

Conversation

@error414

@error414 error414 commented May 31, 2026

Copy link
Copy Markdown
Contributor

The icon input for static custom element icons was restricted to values 0–255. This change raises the limit to 65535 and updates the icon picker to display the full font character set (up to 512 characters), so users can select and save 16-bit icon values that the firmware

image

Inav PR: iNavFlight/inav#11608

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@sonarqubecloud

Copy link
Copy Markdown

@Jetrell

Jetrell commented May 31, 2026

Copy link
Copy Markdown
Collaborator

@sensei-hacker I can confirm this works, if you want to add it with #2560 in 9.1.
Just don't forget to merge the firmware too. As I made the mistake of not loading to begin with.

@sensei-hacker

Copy link
Copy Markdown
Member

Thanks for the test, Jetrell.

"Just don't forget to merge the firmware too." That sounds like the definition of next major version, INAV 10?

@error414

error414 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

firmware is ok, there are no any breaking changes, but in configurator is beraking change, I would preffer to add it to next major version, INAV 10.

@error414

error414 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

BTW: I have to say that I like how new OSD custom elements look like. Nice work @sensei-hacker

@Jetrell

Jetrell commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

BTW: I have to say that I like how new OSD custom elements look like. Nice work @sensei-hacker

This is why I suggested it would be good to add your work here, along with 2560. Because it would effectively make the Custom OSD improvements complete for 9.1.

@error414

error414 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

yeah, but then configurator for INAV 9.1 would not fully work for FW INAV 9.0. I think @sensei-hacker does not want breaking changes in minor versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants