Skip to content

OSD custom elements: add 16-bit icon support #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
error414 wants to merge 2 commits into
base: maintenance-10.x
Choose a base branch
from
+4 −3
Open

OSD custom elements: add 16-bit icon support #2643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
146a5da
OSD custom elements: add 16-bit icon support
error414 May 31, 2026
0beb562
OSD custom elements: fix SonarCloud Code Analysis suggestions
error414 May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tabs/osd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3793,7 +3793,8 @@ function openIconPicker($targetInput) {
var $grid = $('<div>').addClass('ce-icon-picker-grid');
var currentVal = parseInt($targetInput.val()) || 0;

for (var c = 1; c <= 255; c++) {
let maxFontChar = (FONT.data && FONT.data.character_image_urls.length > 0) ? FONT.data.character_image_urls.length - 1 : 511;
for (let c = 1; c <= maxFontChar; c++) {
var url = (FONT.data && FONT.data.character_image_urls[c]) ? FONT.draw(c) : '';
var $tile = $('<div>').addClass('ce-icon-picker-tile')
.attr('data-char', c)
Expand Down Expand Up @@ -3919,7 +3920,7 @@ function buildSlotRow(i, ii) {
$formatSelect.on('change', updateHiddenType);

// Icon picker: hidden input + clickable preview button
var $icoInput = $('<input>').addClass('value').addClass('ico').attr('type', 'hidden').attr('min', 1).attr('max', 255);
let $icoInput = $('<input>').addClass('value').addClass('ico').attr('type', 'hidden').attr('min', 1).attr('max', 65535);
var $icoBtn = $('<div>').addClass('value ico ce-ico-picker-btn').hide()
.append($('<img>').addClass('ce-ico-preview'))
.append($('<span>').addClass('ce-ico-label'));
Expand Down Expand Up @@ -4372,7 +4373,7 @@ function customElementNormaliseRow(row){
valueCell.find('.text').val(valueCell.find('.text').val().replace(/[^A-Z0-9!.\* ]/g, ""));
break;
case 2:
valueCell.find('.ico').val(valueCell.find('.ico').val() > 255 ? 255 : valueCell.find('.ico').val());
valueCell.find('.ico').val(Math.min(valueCell.find('.ico').val(), 65535));
valueCell.find('.ico').val((valueCell.find('.ico').val() != '' && valueCell.find('.ico').val() < 1 )? 1 : valueCell.find('.ico').val());
}
}
Expand Down
Loading