feat: add structured content for response in atlas-local tools - MCP-374#1256
Open
dudaschar wants to merge 6 commits into
Open
feat: add structured content for response in atlas-local tools - MCP-374#1256dudaschar wants to merge 6 commits into
dudaschar wants to merge 6 commits into
Conversation
… tests to directly use structured content
lerouxb
reviewed
Jun 18, 2026
| { deploymentName }: ToolArgs<typeof this.argsShape>, | ||
| { client }: { client: Client } | ||
| ): Promise<CallToolResult> { | ||
| ): Promise<ToolResult<typeof ConnectDeploymentOutputSchema> & Pick<CallToolResult, "_meta">> { |
Member
There was a problem hiding this comment.
Is this change necessary? Looks complicated and I tried this locally without this change and didn't immediately spot any TS errors
Member
There was a problem hiding this comment.
If you want to tighten up the type beyond just Promise<CallToolResult> I think you can look at the existing execute methods that return structuredContent.
Something like Promise<ToolResult<typeof this.outputSchema>> {
lerouxb
reviewed
Jun 18, 2026
| }; | ||
| } | ||
|
|
||
| protected override resolveTelemetryMetadata( |
Member
There was a problem hiding this comment.
I don't see why these changes would be necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2, follow up for #1249
This work enables the output to be provided in structuredContent format which caters for the prompt injection case, but removes the need for additional work on the users side to re-format the output to remove the tags.
This PR apply the updates for the tools inside the atlas-local package, a follow up PR will handle /atlas.
Checklist