Skip to content

chore: update code-health workflow to allow coverage even if flaky tests are failing - MCP-533 #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dudaschar wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −0
Open

chore: update code-health workflow to allow coverage even if flaky tests are failing - MCP-533 #1257

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b20db5
chore: update code-health workflow to allow coverage failures on spec…
dudaschar Jun 17, 2026
c5110f1
chore: update continue on error to be true regarless the test step
dudaschar Jun 17, 2026
f287d3d
Merge branch 'main' into chore-allow-test-coverage-on-failure
dudaschar Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/code-health.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:
- os: ubuntu-latest
node-version: "26"
fail-fast: false
# Ubuntu + Node 22 is the one used for coverage; failures there must not fail the job or block merged coverage.
continue-on-error: ${{ matrix.os == 'ubuntu-latest' && (matrix.node-version == '24' || matrix.node-version == '26') }}

@nirinchev nirinchev Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just set it to a blanket continue-on-error: true? Sounds like we don't want to terminate the matrix jobs if we have a failure in one of them.

@dudaschar dudaschar Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the upload results step (here) I understand the results are only available if node 22 succeed, no if the tests fails for that version we would want to skip coverage indeed. But I'm not too familiar with github actions, if is actually not a problem, we can set as plain true.

@nirinchev nirinchev Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that job.continue-on-error controls the jobs in the matrix. You're right that it would also cause the coverage job to execute even if the (ubuntu, 22) variant fails, but then the download artifact step will fail, thus failing the entire coverage job, which is probably just as good as skipping it entirely.

@dudaschar dudaschar Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I updated the rule to be true. Thanks

runs-on: ${{ matrix.os }}
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
Expand Down
Loading