OCPBUGS-91640: Warn about ignored install-config fields in ABI

[zaneb]

diskSetup and networking.ovnKubernetesConfig were added to the install-config after the agent-based installation method was created, without being plumbed through or generating a warning that its value would be ignored.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced validation warnings for agent install configuration. Users will now receive log warnings when unsupported configuration fields are specified, including disk setup options and internal networking parameters, providing better feedback on configuration usage.

[openshift-ci-robot]

@zaneb: This pull request references Jira Issue OCPBUGS-91640, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

diskSetup and networking.ovnKubernetesConfig were added to the install-config after the agent-based installation method was created, without being plumbed through or generating a warning that its value would be ignored.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 021e6053-7434-4cb1-ae53-ba5d8e133e66

📥 Commits

Reviewing files that changed from the base of the PR and between 1785dc2 and 17410e4.

📒 Files selected for processing (1)

• pkg/asset/agent/installconfig.go

---

📝 Walkthrough

Walkthrough

Three new warning checks are added to the warnUnusedConfig function in pkg/asset/agent/installconfig.go. The function now emits log warnings when compute[].diskSetup, controlPlane.diskSetup, or networking.ovnKubernetesConfig.ipv4.internalJoinSubnet are set in the agent install-config, as these fields are ignored by the agent installer.

Changes

Unused field warnings in agent install-config

Layer / File(s)	Summary
Warn on compute/controlPlane diskSetup and OVN internalJoinSubnet pkg/asset/agent/installconfig.go	warnUnusedConfig adds three new checks: logs a warning when compute[].DiskSetup is non-empty, when controlPlane.DiskSetup is non-empty, and when networking.ovnKubernetesConfig.ipv4.internalJoinSubnet is set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding warnings for ignored install-config fields in agent-based installation, which directly aligns with the PR's purpose of addressing OCPBUGS-91640.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies installconfig.go with warning log statements; no Ginkgo tests (It, Describe, Context, When) are present in the changes, so this check does not apply.
Test Structure And Quality	✅ Passed	PR modifies only pkg/asset/agent/installconfig.go by adding warning log statements; no test files or Ginkgo test code were added/modified, so test quality check is not applicable.
Microshift Test Compatibility	✅ Passed	No Ginkgo e2e tests were added in this PR. The change adds warning messages to a production code file (pkg/asset/agent/installconfig.go) only; check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies production code only (pkg/asset/agent/installconfig.go). No Ginkgo e2e tests added; check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds only logging warnings for ignored install-config fields. Contains no deployment manifests, operator code, controllers, or scheduling constraints. Topology-aware scheduling check is not appl...
Ote Binary Stdout Contract	✅ Passed	Code adds logrus.Warnf() calls in warnUnusedConfig(), a runtime validation method called during asset loading—not process-level code. Logrus defaults to stderr, not stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. Changes are limited to pkg/asset/agent/installconfig.go, adding warning messages to warnUnusedConfig() function for ignored configuration fields. The check...
No-Weak-Crypto	✅ Passed	No cryptographic operations found. Changes only add warning logs for ignored config fields in agent-based installation validation.
Container-Privileges	✅ Passed	PR modifies only Go installer configuration validation code, adding log warnings. No container manifests, Dockerfiles, or container/K8s privilege escalation settings are present or modified.
No-Sensitive-Data-In-Logs	✅ Passed	The three new log warnings do not expose sensitive data: two warn only about field paths, one logs an internal subnet CIDR (non-sensitive network configuration).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@zaneb: This pull request references Jira Issue OCPBUGS-91640, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

diskSetup and networking.ovnKubernetesConfig were added to the install-config after the agent-based installation method was created, without being plumbed through or generating a warning that its value would be ignored.

Summary by CodeRabbit

• Bug Fixes
• Enhanced validation warnings for agent install configuration. Users will now receive log warnings when unsupported configuration fields are specified, including disk setup options and internal networking parameters, providing better feedback on configuration usage.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rwsu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/asset/agent/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage	17410e4	link	false	/test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/e2e-agent-two-node-fencing-ipv4	17410e4	link	false	/test e2e-agent-two-node-fencing-ipv4
ci/prow/e2e-agent-5control-ipv4	17410e4	link	false	/test e2e-agent-5control-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.