Skip to content

OCPBUGS-91640: Warn about ignored install-config fields in ABI #10646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaneb wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −0
Open

OCPBUGS-91640: Warn about ignored install-config fields in ABI #10646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b4374
Warn when diskSetup is set in ABI
zaneb Jun 23, 2026
17410e4
Warn when ovnKubernetesConfig is set in ABI
zaneb Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pkg/asset/agent/installconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,11 @@ func warnUnusedConfig(installConfig *types.InstallConfig) {
fieldPath := computePath.Child("platform")
logrus.Warnf("%s is ignored", fieldPath)
}

if len(compute.DiskSetup) > 0 {
fieldPath := computePath.Child("diskSetup")
logrus.Warnf("%s is ignored", fieldPath)
}
}

if installConfig.ControlPlane.Hyperthreading != "Enabled" {
Expand All @@ -473,6 +478,11 @@ func warnUnusedConfig(installConfig *types.InstallConfig) {
logrus.Warnf("%s is ignored", fieldPath)
}

if len(installConfig.ControlPlane.DiskSetup) > 0 {
fieldPath := field.NewPath("controlPlane", "diskSetup")
logrus.Warnf("%s is ignored", fieldPath)
}

switch installConfig.Platform.Name() {

case baremetal.Name:
Expand Down Expand Up @@ -571,6 +581,14 @@ func warnUnusedConfig(installConfig *types.InstallConfig) {
}
}

if installConfig.Networking != nil &&
installConfig.Networking.OVNKubernetesConfig != nil &&
installConfig.Networking.OVNKubernetesConfig.IPv4 != nil &&
installConfig.Networking.OVNKubernetesConfig.IPv4.InternalJoinSubnet != nil {
fieldPath := field.NewPath("networking", "ovnKubernetesConfig", "ipv4", "internalJoinSubnet")
logrus.Warnf("%s: %s is ignored", fieldPath, installConfig.Networking.OVNKubernetesConfig.IPv4.InternalJoinSubnet)
}

// "External" is the default set from generic install config code
if installConfig.Publish != "External" {
fieldPath := field.NewPath("publish")
Expand Down