Add nfc-ethernet DUT pairing mode for python_testing suites - #351
Add nfc-ethernet DUT pairing mode for python_testing suites#351rquidute wants to merge 1 commit into
Conversation
Add NFC_ETHERNET to DutPairingModeEnum and NFC_PAIRING_MODES so python_testing (SDK) tests can commission Matter-over-Ethernet devices via NFC, mirroring the connectedhomeip Python controller support already merged upstream (project-chip/connectedhomeip#43657). generate_command_arguments() requires no code change: since nfc-ethernet is not part of the wifi or thread pairing-mode tuples, it falls straight through to the existing NFC handling that suppresses --discriminator/--passcode and injects NFC_Reader_index. YAML/chip-tool test support is intentionally out of scope here, since chip-tool itself does not support nfc-ethernet yet (project-chip/connectedhomeip#43613 is still open upstream). Adds test coverage mirroring the existing nfc-wifi/nfc-thread tests in test_utils.py and test_test_environment_config.py. Related: project-chip/certification-tool#1067
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change adds 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
|
@coderabbitai review full |
|
✅ Action performedFull review finished. |
Summary
Adds
nfc-ethernetas a valid DUT pairing mode for python_testing (SDK) tests only, so the Test Harness can commission Matter-over-Ethernet devices via NFC.Background
nfc-ethernetto chip-tool) is still open, so YAML/chip-tool-based tests can't use this mode yet.connectedhomeipsubmodule, so python_testing (SDK) tests can already acceptnfc-ethernetas a--commissioning-method— this PR just exposes/maps it in the TH's config/dispatch layer.Changes
app/constants/shared_constants.py: addedNFC_ETHERNET = "nfc-ethernet"toDutPairingModeEnumand toNFC_PAIRING_MODES.generate_command_arguments()inpython_testing/models/utils.pyneeded no code change: nfc-ethernet isn't part of the wifi/thread pairing-mode tuples, so it falls straight through to the existing NFC handling that suppresses--discriminator/--passcodeand injectsNFC_Reader_index.test_suite.pyOTBR setup needed no change: nfc-ethernet is not in the BLE_THREAD/NFC_THREAD/THREAD_MESHCOP tuple that triggers OTBR startup.test_collections/matter/sdk_tests/support/tests/python_tests/test_utils.pytest_collections/matter/sdk_tests/support/tests/matter/test_test_environment_config.pyOut of scope
Related: project-chip/certification-tool#1067