fix(docs): align base data-table docs with Base dropdown menu render API#10935
Open
junhaoliao wants to merge 3 commits into
Open
fix(docs): align base data-table docs with Base dropdown menu render API#10935junhaoliao wants to merge 3 commits into
junhaoliao wants to merge 3 commits into
Conversation
Contributor
|
@junhaoliao is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
junhaoliao
changed the title
junhaoliao
force-pushed
the
fix/10934-base-dropdownmenu-trigger
branch
from
63ad03b to
3ccca29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes issue #10934: the Base UI Data Table docs used Radix-style
asChildonDropdownMenuTrigger, which is incompatible with Base UI docs/style.Changes
apps/v4/content/docs/components/base/data-table.mdxto useDropdownMenuTrigger'srenderprop in both affected snippets (row actions menu and column visibility menu).Validation
pnpm run lint(repo root): pass.pnpm --filter=v4 exec prettier --check content/docs/components/base/data-table.mdx: pass.Fixes #10934