Skip to content

fix(docs): align base data-table docs with Base dropdown menu render API #10935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junhaoliao wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −11
Open

fix(docs): align base data-table docs with Base dropdown menu render API #10935

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ccca29
fix: align base data table dropdown trigger usage with Base UI API
junhaoliao Jun 13, 2026
0ae5de2
Merge branch 'main' into fix/10934-base-dropdownmenu-trigger
junhaoliao Jun 16, 2026
7232a59
Merge branch 'main' into fix/10934-base-dropdownmenu-trigger
junhaoliao Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions apps/v4/content/docs/components/base/data-table.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,12 +349,14 @@ export const columns: ColumnDef<Payment>[] = [

return (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="ghost" className="h-8 w-8 p-0">
<span className="sr-only">Open menu</span>
<MoreHorizontal className="h-4 w-4" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuTrigger
render={
<Button variant="ghost" className="h-8 w-8 p-0">
<span className="sr-only">Open menu</span>
<MoreHorizontal className="h-4 w-4" />
</Button>
}
/>
<DropdownMenuContent align="end">
<DropdownMenuLabel>Actions</DropdownMenuLabel>
<DropdownMenuItem
Expand Down Expand Up @@ -694,11 +696,13 @@ export function DataTable<TData, TValue>({
className="max-w-sm"
/>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="outline" className="ml-auto">
Columns
</Button>
</DropdownMenuTrigger>
<DropdownMenuTrigger
render={
<Button variant="outline" className="ml-auto">
Columns
</Button>
}
/>
<DropdownMenuContent align="end">
{table
.getAllColumns()
Expand Down
Loading