docs(base/data-table): replace asChild with render prop in DropdownMenuTrigger#10980
Open
creazyfrog wants to merge 1 commit into
Open
docs(base/data-table): replace asChild with render prop in DropdownMenuTrigger#10980creazyfrog wants to merge 1 commit into
creazyfrog wants to merge 1 commit into
Conversation
Contributor
|
@creazyfrog is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
…nuTrigger examples (fixes shadcn-ui#10934)
creazyfrog
force-pushed
the
fix/10934-base-data-table-asChild-to-render
branch
from
07e1dd2 to
f3e80bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asChildprop onDropdownMenuTrigger, inconsistent with Base UI'srenderprop APIrender={<Button ... />}pattern, matching the Base Dropdown Menu docsChanges
apps/v4/content/docs/components/base/data-table.mdx: replaced<DropdownMenuTrigger asChild><Button .../></DropdownMenuTrigger>with<DropdownMenuTrigger render={<Button ... />}>in two places (row actions and column visibility snippets)Testing
Docs-only change — no runtime behavior modified. Verified the updated snippets match the pattern used in
apps/v4/content/docs/components/base/dropdown-menu.mdx.Closes #10934
🤖 Generated with Claude Code