Skip to content

docs(base/data-table): replace asChild with render prop in DropdownMenuTrigger #10980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
creazyfrog wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −9
Open

docs(base/data-table): replace asChild with render prop in DropdownMenuTrigger #10980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions apps/v4/content/docs/components/base/data-table.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,11 +349,9 @@ export const columns: ColumnDef<Payment>[] = [

return (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="ghost" className="h-8 w-8 p-0">
<span className="sr-only">Open menu</span>
<MoreHorizontal className="h-4 w-4" />
</Button>
<DropdownMenuTrigger render={<Button variant="ghost" className="h-8 w-8 p-0" />}>
<span className="sr-only">Open menu</span>
<MoreHorizontal className="h-4 w-4" />
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
<DropdownMenuLabel>Actions</DropdownMenuLabel>
Expand Down Expand Up @@ -694,10 +692,8 @@ export function DataTable<TData, TValue>({
className="max-w-sm"
/>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="outline" className="ml-auto">
Columns
</Button>
<DropdownMenuTrigger render={<Button variant="outline" className="ml-auto" />}>
Columns
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
{table
Expand Down
Loading